[PATCH] D153453: [MemCpyOpt] implement single BB stack-move optimization which unify the static unescaped allocas

Kohei Asano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 04:24:01 PDT 2023


khei4 added a comment.

@nikic

> We shouldn't use dominates() in this patch, as it's not always semantically correct. Just the BB check you added should be enough to fix the issue, no?

Thanks! Right! The semantics would be different (strict?) from the multi-BB case, and checking is enough to prevent crashes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153453/new/

https://reviews.llvm.org/D153453



More information about the llvm-commits mailing list