[PATCH] D155283: [RISCV] Cleanups in CORE-V (xcv) extensions

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 04:02:23 PDT 2023


asb added a comment.

The fact this slipped through without an entry in RISCVISAInfo suggests we were missing test coverage in attribute-arch.s and/or attributes.ll for the emitted extension version. Your changes so far all LGTM, but please take a look at those tests. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155283/new/

https://reviews.llvm.org/D155283



More information about the llvm-commits mailing list