[PATCH] D155132: [amdgpu][lds] Raise an explicit unimplemented error on absolute address LDS variables

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:358
+      if (GV.isAbsoluteSymbolRef()) {
+        report_fatal_error(
+            "LDS variables with absolute addresses are unimplemented.");
----------------
LLVMContext::emitError is a lazier way than going through the full diagnostic. You still need to produce some result though, so usually just replace with poison/undef 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155132/new/

https://reviews.llvm.org/D155132