[PATCH] D155132: [amdgpu][lds] Raise an explicit unimplemented error on absolute address LDS variables

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 03:35:08 PDT 2023


JonChesterfield added a comment.

In D155132#4496383 <https://reviews.llvm.org/D155132#4496383>, @jmmartinez wrote:

> I was thinking about using `LLVMContext::diagnose` + `DiagnosticInfoUnsupported` but it seems there is no alternative for GlobalVariables (only for Functions) and adding support for it is a whole other patch.

Interesting. That probably is something LLVM should have available. In this case, I'm hoping we'll implement this (put the variable at the requested location in the kernels that can reach it) as opposed to improving the diagnostics, though that may be unimplementable in the context of separate compilation (which is also not yet implemented).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155132/new/

https://reviews.llvm.org/D155132



More information about the llvm-commits mailing list