[PATCH] D154281: [CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.

Thu Jul 13 01:49:19 PDT 2023

foad added a reviewer: sepavloff.
foad added a comment.

In D154281#4493757 <https://reviews.llvm.org/D154281#4493757>, @foad wrote:

> In D154281#4493465 <https://reviews.llvm.org/D154281#4493465>, @arsenm wrote:
>
>> Should the verifier check the block stored adjustment matches the calls in the block?
>
> That would be nice, and it would fit naturally in MachineVerifier::verifyStackFrame. But after PEI eliminates call frame setup instructions, you can no longer infer the SP adjustment by examining the instructions in a block. I don't know how to handle that case.

I am tempted to revert this patch while I work on the machine verification aspect. I am having second thoughts about whether "sp adjustment" is the right abstraction to store in the basic block - maybe "frame size" or "frame total size" would make more sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154281/new/

https://reviews.llvm.org/D154281