[PATCH] D154606: [PowerPC] Add DFP test instruction definitions and MC tests

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:100
+def DTSTDCQ : Z22Form_BF3_FRA5_DCM6<63, 194, (outs crrc:$BF),
+                                   (ins fpairrc:$FRA, u6imm:$DCM),
+                                   "dtstdcq $BF, $FRA, $DCM", IIC_FPCompare, []>;
----------------
nit: indent the following 2 lines 1 more space


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:112
+def DTSTEX : XForm_17<59, 162, (outs crrc:$BF), (ins f8rc:$RA, f8rc:$RB),
+                     "dtstex $BF, $RA, $RB", IIC_FPCompare>;
+
----------------
nit: the 2nd line for this and the next 3 instr require 1 more space in indent


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:128
+def DTSTSFIQ : XForm_BF3_UIM6_FRB5<63, 675, (outs crrc:$BF),
+                                  (ins u6imm:$UIM, fpairrc:$FRB),
+                                  "dtstsfiq $BF, $UIM, $FRB", IIC_FPCompare, []>;
----------------
nit: indent


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154606/new/

https://reviews.llvm.org/D154606