[PATCH] D154606: [PowerPC] Add DFP test instruction definitions and MC tests

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 10:17:24 PDT 2023


amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.

I think since we discussed offline that the Z22 forms extended opcode should start at 22, this LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrFormats.td:1225
+class XForm_BF3_UIM6_FRB5<bits<6> opcode, bits<10> xo, dag OOL, dag IOL,
+                      string asmstr, InstrItinClass itin, list<dag> pattern>
+  : I<opcode, OOL, IOL, asmstr, itin> {
----------------
nit: Indentation


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrFormats.td:2153
+class Z22Form_BF3_FRA5_DCM6<bits<6> opcode, bits<9> xo, dag OOL, dag IOL,
+                      string asmstr, InstrItinClass itin, list<dag> pattern>
+  : I<opcode, OOL, IOL, asmstr, itin> {
----------------
nit: Indentation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154606/new/

https://reviews.llvm.org/D154606



More information about the llvm-commits mailing list