[PATCH] D155013: [compiler-rt][xray] Fix alignment of XRayFileHeader

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_fdr_logging.cpp:18-19
 #include <cassert>
+#include <cstddef>
 #include <errno.h>
 #include <limits>
----------------
luporl wrote:
> fmayer wrote:
> > Random driveby: why do we mix <cfoo> and <foo.h>?
> I don't know why, but to my knowledge it's better to use <cfoo> in C++, when possible, to avoid polluting the global namespace.
Yes, but in practice <cfoo> and <foo.h> can be mixed: https://maskray.me/blog/2022-05-15-c-standard-library-headers-in-c++


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155013/new/

https://reviews.llvm.org/D155013