[PATCH] D155013: [compiler-rt][xray] Fix alignment of XRayFileHeader
Leandro Lupori via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 12 11:34:58 PDT 2023
luporl added inline comments.
================
Comment at: compiler-rt/lib/xray/xray_fdr_logging.cpp:18-19
#include <cassert>
+#include <cstddef>
#include <errno.h>
#include <limits>
----------------
fmayer wrote:
> Random driveby: why do we mix <cfoo> and <foo.h>?
I don't know why, but to my knowledge it's better to use <cfoo> in C++, when possible, to avoid polluting the global namespace.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155013/new/
https://reviews.llvm.org/D155013
More information about the llvm-commits
mailing list