[PATCH] D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:4230
 
   // Ensure that the constant occurs on the RHS and fold constant comparisons.
   // TODO: Handle non-splat vector constants. All undef causes trouble.
----------------
Doesn't this change prevent folding constant comparisons? But maybe that's handled by the FoldSetCC above? Was that added later than this comment was written?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155095/new/

https://reviews.llvm.org/D155095