[PATCH] D154665: [Object] fixed invalid symbol handling in ELFObjectFile::getSymbolName

Wed Jul 12 08:31:05 PDT 2023

mtrofin added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/ELF/section-symbols.test:23
+## Test that we consume an error in ELFObjectFile<ELFT>::getSectionName when disassembling. 
+# RUN: llvm-objdump -d --syms %t1 2>&1 | \
+# RUN:   FileCheck %s -DFILE=%t1 --check-prefix=CHECK-DISAS
----------------
luporl wrote:
> michaelplatings wrote:
> > chapuni wrote:
> > > Disassembling doesn't work if x86 is not configured.
> > Yes, this test is failing in my build with -DLLVM_TARGETS_TO_BUILD="AArch64;ARM"
> This also broke some bots:
>   - https://lab.llvm.org/buildbot/#/builders/245/builds/10929
>   - https://lab.llvm.org/buildbot/#/builders/188/builds/32254
>   - https://lab.llvm.org/buildbot/#/builders/65/builds/10478
> 
> 
@JestrTulip @MaskRay judging from line 32, the test should require x86 target? Or `-r` is expected to run anyway, and it's just `-d` that can't, and thus should be split off in its own `X86/section-symbols-disassemble.test` maybe (to give it a name)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154665/new/

https://reviews.llvm.org/D154665