[PATCH] D154665: [Object] fixed invalid symbol handling in ELFObjectFile::getSymbolName

Wed Jul 12 07:26:16 PDT 2023

luporl added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/ELF/section-symbols.test:23
+## Test that we consume an error in ELFObjectFile<ELFT>::getSectionName when disassembling. 
+# RUN: llvm-objdump -d --syms %t1 2>&1 | \
+# RUN:   FileCheck %s -DFILE=%t1 --check-prefix=CHECK-DISAS
----------------
michaelplatings wrote:
> chapuni wrote:
> > Disassembling doesn't work if x86 is not configured.
> Yes, this test is failing in my build with -DLLVM_TARGETS_TO_BUILD="AArch64;ARM"
This also broke some bots:
  - https://lab.llvm.org/buildbot/#/builders/245/builds/10929
  - https://lab.llvm.org/buildbot/#/builders/188/builds/32254
  - https://lab.llvm.org/buildbot/#/builders/65/builds/10478

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154665/new/

https://reviews.llvm.org/D154665