[PATCH] D149058: [BPF][DebugInfo] Use .BPF.ext for line info when DWARF is not available

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thank!



================
Comment at: llvm/include/llvm/DebugInfo/BTF/BTFContext.h:22
+
+class BTFContext : public DIContext {
+  BTFParser BTF;
----------------



================
Comment at: llvm/test/tools/llvm-objdump/BPF/interleaved-source-test.ll:44
+; CHECK-EMPTY:
+; CHECK-NEXT: {{[0-9a-f]+}} <foo>:
+; CHECK-NEXT: ;   consume(1);
----------------
eddyz87 wrote:
> MaskRay wrote:
> > We can use `[[#%x,]]`, but the convention is probably to just use `; CHECK-NEXT: <foo>:`.
> You [[ https://reviews.llvm.org/D149058#inline-1484679 | asked ]] to check function address in the disassembly, so I added regex to match the address. Changed to `[[#%x,]]` in the new version.
Ah, sounds good. This makes it clear that there is an address.


================
Comment at: llvm/unittests/DebugInfo/BTF/BTFParserTest.cpp:15
+using namespace llvm;
+using namespace object;
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149058/new/

https://reviews.llvm.org/D149058