[PATCH] D149058: [BPF][DebugInfo] Use .BPF.ext for line info when DWARF is not available

Eduard Zingerman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 09:50:20 PDT 2023


eddyz87 added a comment.

Hi @MaskRay , @nickdesaulniers,

Thanks a lot for reviewing the patch!



================
Comment at: llvm/test/tools/llvm-objdump/BPF/interleaved-source-test.ll:44
+; CHECK-EMPTY:
+; CHECK-NEXT: {{[0-9a-f]+}} <foo>:
+; CHECK-NEXT: ;   consume(1);
----------------
MaskRay wrote:
> We can use `[[#%x,]]`, but the convention is probably to just use `; CHECK-NEXT: <foo>:`.
You [[ https://reviews.llvm.org/D149058#inline-1484679 | asked ]] to check function address in the disassembly, so I added regex to match the address. Changed to `[[#%x,]]` in the new version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149058/new/

https://reviews.llvm.org/D149058



More information about the llvm-commits mailing list