[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-if-else/test.txt:9
 # RUN: %if feature %{ echo "test-1" %}
-# CHECK-NEXT: {{^.*'RUN}}: at line [[#@LINE-1]]'; echo "test-1"
+#  CHECK-NEXT: {{^.*"RUN}}: at line [[#@LINE-1]]"
+#       CHECK: # command output:
----------------
awarzynski wrote:
> IIUC, full RUN line would be printed here, right?
Yes.  Previously, this test was looking in the "Script:" section to verify correct expansion of `%if`.  Now that "Script:" is gone, I changed it to just look for correct stdout from the executed command.  Perhaps I should have changed it to look at the printed RUN line (from -vv)?  What do you think?  @asavonic might also want to comment, as he wrote the original test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984