[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

Tue Jul 11 14:50:15 PDT 2023

jdenny added a comment.

In D154984#4491339 <https://reviews.llvm.org/D154984#4491339>, @awarzynski wrote:

> This is a very nice clean-up, thanks!
>
> I've only skimmed through so far and just wanted to post a quick question about this:

Thanks for taking a look.

>> **Change**: After this patch, there is no "Script:" section
>
> IMO, it would be nice to be able to simply print the `RUN` lines that LIT has collected.  Especially for complex tests for which `RUN` lines depend on various CMake flags (to help developing such tests).

In case it wasn't clear, with this patch, you do see the fully expanded RUN lines that actually execute, as in the trace of any shell language (or any that I've used).

If a RUN line fails, you don't see the remaining RUN lines that didn't execute.  Are you saying you would like to see those too?  In my usage, I have never wanted to because I always wanted to address the current failure and then retry before looking any farther in case there's an interaction.  Can you help me to understand your use case a bit more?

> So, I would keep the "Script" section, but:
>
> - only print it when explicitly requested (with a dedicated flag, e.g. `-print-script`),
> - make it default to "collect the RUN lines, print them and exit" (so the tests wouldn't run).
>
> Would this be difficult and would it make sense to you? Or perhaps that's already supported? :)

This patch does not currently support that.  It would not be difficult now but will require more thought if something like the PYTHON directive is accepted, especially if they grown the ability to affect substitutions and thus subsequent RUN lines.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984