[PATCH] D153757: [RFC][TableGen][GlobalISel] Add Combiner Match Table Backend

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh marked an inline comment as done.
Pierre-vh added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp:1392
+        "{\n"
+     << "  switch(ApplyID) {\n";
+  for (const auto &Apply : ApplyCode) {
----------------
RKSimon wrote:
> @Pierre-vh I'm seeing build warnings due to empty switch statements:
> ```
> E:\llvm\ninja\lib\Target\Mips\MipsGenPostLegalizeGICombiner.inc(249): warning C4060: switch statement contains no 'case' or 'default' labels
> ```
> Please can you wrap this in a  if (!ApplyCode.empty()) like you did above?
Sure, apologies for the inconvenience. Will do ASAP.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153757/new/

https://reviews.llvm.org/D153757