[PATCH] D153757: [RFC][TableGen][GlobalISel] Add Combiner Match Table Backend
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 11 02:50:20 PDT 2023
RKSimon added inline comments.
================
Comment at: llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp:1392
+ "{\n"
+ << " switch(ApplyID) {\n";
+ for (const auto &Apply : ApplyCode) {
----------------
@Pierre-vh I'm seeing build warnings due to empty switch statements:
```
E:\llvm\ninja\lib\Target\Mips\MipsGenPostLegalizeGICombiner.inc(249): warning C4060: switch statement contains no 'case' or 'default' labels
```
Please can you wrap this in a if (!ApplyCode.empty()) like you did above?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153757/new/
https://reviews.llvm.org/D153757
More information about the llvm-commits
mailing list