[PATCH] D154507: [NVPTX] Apply global var demotion to private symbols

Mon Jul 10 17:06:53 PDT 2023

tra added a comment.

In D154507#4487074 <https://reviews.llvm.org/D154507#4487074>, @mehdi_amini wrote:

> In D154507#4486860 <https://reviews.llvm.org/D154507#4486860>, @tra wrote:
>
>> This may be potentially problematic for CUDA as we may need to refer to the global variable from the host side. E.g. via `cudaMemcpyFromSymbol/cudaMemcpyToSymbol`.
>
> If something is to be referenced from outside a LLVM module, shouldn't we just avoid making it internal in the first place? Neither internal nor private are supposed to be visible outside the current module I believe.

Please ignore, I missed that this demotion only applies to the shared variables which can't be accessed from the host that way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154507/new/

https://reviews.llvm.org/D154507