[PATCH] D154507: [NVPTX] Apply global var demotion to private symbols

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 15:06:22 PDT 2023


mehdi_amini added a comment.

In D154507#4486860 <https://reviews.llvm.org/D154507#4486860>, @tra wrote:

> This may be potentially problematic for CUDA as we may need to refer to the global variable from the host side. E.g. via `cudaMemcpyFromSymbol/cudaMemcpyToSymbol`.

If something is to be referenced from outside a LLVM module, shouldn't we just avoid making it internal in the first place? Neither internal nor private are supposed to be visible outside the current module I believe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154507/new/

https://reviews.llvm.org/D154507



More information about the llvm-commits mailing list