[PATCH] D154765: APFloat: Add some missing function declarations

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 12:15:38 PDT 2023


nikic added a comment.

Oh, I see. I think the reason this works is ADL, which also finds friend declarations even if not declared at namespace level.



================
Comment at: llvm/include/llvm/ADT/APFloat.h:1430
+DoubleAPFloat scalbn(const DoubleAPFloat &Arg, int Exp, APFloat::roundingMode RM);
+DoubleAPFloat frexp(const DoubleAPFloat &X, int &Exp, APFloat::roundingMode);
 
----------------
These declarations should probably be next to `hash_code hash_value(const DoubleAPFloat &Arg);` above, rather than these definitions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154765/new/

https://reviews.llvm.org/D154765



More information about the llvm-commits mailing list