[PATCH] D154765: APFloat: Add some missing function declarations

Mon Jul 10 12:06:21 PDT 2023

arsenm added a comment.

In D154765#4486303 <https://reviews.llvm.org/D154765#4486303>, @arsenm wrote:

> In D154765#4486299 <https://reviews.llvm.org/D154765#4486299>, @nikic wrote:
>
>> In D154765#4486295 <https://reviews.llvm.org/D154765#4486295>, @arsenm wrote:
>>
>>> In D154765#4486268 <https://reviews.llvm.org/D154765#4486268>, @nikic wrote:
>>>
>>>> In D154765#4486245 <https://reviews.llvm.org/D154765#4486245>, @arsenm wrote:
>>>>
>>>>> These should be used for constant folding of ldexp and frexp
>>>>
>>>> We probably don't support constant folding for pcc_fp128. Or at least I don't see how it would work without the declarations.
>>>
>>> D149587 <https://reviews.llvm.org/D149587> introduces the constant folding of ldexp. I haven't gotten around to posting the frexp patch yet
>>
>> This is working on APFloat though, not on DoubleAPFloat.
>
> There's supposed to be a APFLOAT_DISPATCH_ON_SEMANTICS wrapper around ~everything

Which we already have so now I'm confused

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154765/new/

https://reviews.llvm.org/D154765