[PATCH] D154638: Emit a .debug_addr section with dsymutil

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham added inline comments.


================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:642
+      DenseMap<uint64_t, uint64_t> &AddrIndexMap;
+      std::vector<uint64_t> &Addrs;
+      uint64_t Index;
----------------
avl wrote:
> llvm coding standard suggests to use SmallVector instead std::vector. https://llvm.org/docs/CodingStandards.html#c-standard-library
I was just being consistent because `DIECloner::DIECloner()` takes a `std::vector<std::unique_ptr<CompileUnit>> &CompileUnits,` maybe that should be changed to? 


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:2579
+      if (DwarfVersion >= 5)
+        Linker.emitDebugAddrSection(*CurrentUnit, AddrPool.Addrs);
+      AddrPool.clear();
----------------
avl wrote:
> probably, the dwarf::DW_AT_addr_base should be updated here with the proper offset to .debug_addr section.
Correct me if I am wrong, but there doesn't seem to be a way to modify the value of an attribute in the die after it has already been set right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638