[PATCH] D154638: Emit a .debug_addr section with dsymutil

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham updated this revision to Diff 538519.
rastogishubham marked 6 inline comments as done.
rastogishubham added a comment.

Addressed review comments:

1. Added a Doxygen comment for `void emitAddrs`

2. Replaced `std::vector` usage with `SmallVector`

3. Created function `DebugAddrPool:: getAddrIndex` to keep track of Addresses in a Compile Unit

4. Removed global AddrIndexMap and Addrs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/test/tools/dsymutil/ARM/dwarf5-addrx-0x0-last.test
  llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test
  llvm/test/tools/dsymutil/ARM/dwarf5-macho.test
  llvm/test/tools/dsymutil/X86/dwarf5-addrx.test
  llvm/test/tools/dsymutil/X86/dwarf5-dw-op-addrx.test
  llvm/test/tools/dsymutil/X86/dwarf5-rnglists.test
  llvm/test/tools/dsymutil/X86/op-convert-offset.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-addresses.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-rnglists.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154638.538519.patch
Type: text/x-patch
Size: 27972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230710/52bf3749/attachment.bin>