[PATCH] D148744: [InstCombine] Refactor foldSelectICmpAndOr to use `decomposeBitTestICmp` instead of bespoke logic

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n marked 2 inline comments as done.
goldstein.w.n added inline comments.
Herald added a subscriber: wangpc.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:697
+    C1Log = C1.logBase2();
+    NeedAnd = !match(CmpRHS, m_SpecificInt(C1));
   }
----------------
nikic wrote:
> I don't really get why this isn't `NeedAnd = true` any more.
Can't remember why I changed that. Probably was a mistake either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148744/new/

https://reviews.llvm.org/D148744