[PATCH] D154791: [InstCombine] Transform bitwise (A << X, zext(icmp)) -> zext (bitwise(A < 0, icmp)) fold.

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 9 11:56:53 PDT 2023


goldstein.w.n added a comment.

Throughout the comments/summary/title can you replace `X` with `C` to indicate its a constant. Also in a few places you forget the `-1` in its description as `sizeof_bits(A) - 1`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154791/new/

https://reviews.llvm.org/D154791



More information about the llvm-commits mailing list