[PATCH] D148417: [compiler-rt][profiling] Add an incremental buffer writing mode to libprofile

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingBuffer.c:237
+  BytesWrittenAndBytesLeftover WrittenAndLeftover;
+  int NumBytesWritten = 0;
+  do {
----------------
Should this be a uint64_t, since the struct's `NumBytesWritten` has that type? Likewise, shouldn't the return type be changed to match?


================
Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:462
+
+  // Don't support writing binary IDs in this mode right now.
+  if (Header.BinaryIdsSize) {
----------------
I think the comment should elaborate a little on why this isn't supported yet, what makes it tricky or a lot of work or whatever.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148417/new/

https://reviews.llvm.org/D148417