[PATCH] D154777: [LLD] [COFF] Warn about pseudo relocations that are too narrow

[Alvin Wong via Phabricator via llvm-commits]

alvinhochun added a comment.

Sounds like a good diagnostic to me. For the warning message perhaps it can be changed a bit to avoid using a full stop?

  runtime pseudo relocation in [...] against symbol [...] is too narrow (only 32 bits wide); this will fail at runtime depending on memory layout

I also think it can use a slightly stronger tone than "can fail", maybe even worth being an error by default. With HEASLR being the default nowadays, 32-bit pseudo relocations seems like a recipe for failure, is it not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154777/new/

https://reviews.llvm.org/D154777