[PATCH] D154766: [GlobalISel] convergent intrinsics

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:859
 
-G_INTRINSIC, G_INTRINSIC_W_SIDE_EFFECTS
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+G_INTRINSIC and variants
+^^^^^^^^^^^^^^^^^^^^^^^^
----------------
Could you please out all four of them? It is easier to read for me.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:864
 
-The _W_SIDE_EFFECTS version is considered to have unknown side-effects and
+The _W_SIDE_EFFECTS variant is considered to have unknown side-effects and
 as such cannot be reordered across other side-effecting instructions.
----------------
I would argue that it has to be plural. `the x variants`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154766/new/

https://reviews.llvm.org/D154766