[PATCH] D154754: [llvm-objdump] Change errors to warnings for symbol section name dumping

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.h:120
 
+class Dumper {
+  const object::ObjectFile &O;
----------------
nit: `final`


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.h:120
 
+class Dumper {
+  const object::ObjectFile &O;
----------------
mtrofin wrote:
> nit: `final`
How about renaming this to `WarningsCollector` and scoping it down to just managing the warnings, and then the `print` functions that can tolerate failures take it as a parameter (instead of being its members)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154754/new/

https://reviews.llvm.org/D154754