[PATCH] D72680: [ms] [llvm-ml] Add a draft MASM parser

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.
Herald added a subscriber: pengfei.
Herald added a project: All.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:599
   default:
-    // Handle identifier: [a-zA-Z_.][a-zA-Z0-9_$.@]*
-    if (isalpha(CurChar) || CurChar == '_' || CurChar == '.')
-      return LexIdentifier();
+    if (MAI.doesAllowSymbolAtNameStart()) {
+      // Handle Microsoft-style identifier: [a-zA-Z_$.@?][a-zA-Z0-9_$.@?]*
----------------
The code was refactored by D99889. As of today, there is no test for `?` at the start of a symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72680/new/

https://reviews.llvm.org/D72680