[PATCH] D154594: Add version comparison in BooleanExpression for lit testing
Louis Dionne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 7 14:32:51 PDT 2023
ldionne added a comment.
Something like this would be extremely useful in the libc++ test suite! However, IMO it would be a lot more useful if we could:
1. Expand substitutions in these expressions (do we do that?)
2. Do string matching as well. That way I could do something like `REQUIRES: %{stdlib} == libcxx`. I wouldn't actually do that exactly, but you get the point.
In fact, after that, I don't think we need the `available_versions` part of the config anymore. You just add a substitution like `%{a-version}` and then you just have to check for `%{a-version} > 4`. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154594/new/
https://reviews.llvm.org/D154594
More information about the llvm-commits
mailing list