[PATCH] D138883: [PowerPC] find and reuse ConstantSplatVector to combine constant store into extract and store

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

In D138883#4479380 <https://reviews.llvm.org/D138883#4479380>, @tingwang wrote:

> Rebase and added some comments.
>
> Hi @nemanjai, I accepted and addressed your previous comments. Do you have any more concerns on the approach that is implemented here? Thank you!

I am really sorry about the delay...
While I am not completely opposed to this, it seems like a fair bit of machinery to add for something that we could solve more simply with unaligned stores (i.e. the same way we would codegen a `memset` where the tail is *not* a power of 2).

I don't think that

  xxspltib 0, 165
  li 4, 16
  stxsibx 0, 3, 4
  stxv 0, 0(3)

is any better than

  xxspltib 0, 165
  li 4, 1
  stxvx 0, 3, 4
  stxv 0, 0(3)

Is it possible to do something like that without walking the chain and with existing capabilities?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138883/new/

https://reviews.llvm.org/D138883