[llvm] 64d3254 - AMDGPU: Delete custom combine on class intrinsic

[Matt Arsenault via llvm-commits]

Author: Matt Arsenault
Date: 2023-07-07T15:28:21-04:00
New Revision: 64d325454bc0adb468026c74aa077594ff820a07

URL: https://github.com/llvm/llvm-project/commit/64d325454bc0adb468026c74aa077594ff820a07
DIFF: https://github.com/llvm/llvm-project/commit/64d325454bc0adb468026c74aa077594ff820a07.diff

LOG: AMDGPU: Delete custom combine on class intrinsic

This is no longer necessary as class-with-constant will always be
transformed to the generic class intrinsic.

https://reviews.llvm.org/D153901

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp

Removed: 
    llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-foldnegate.ll


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp b/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
index 65f1ed5f97a33d..618beb80615229 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
@@ -235,7 +235,6 @@ class AMDGPUCodeGenPrepareImpl
 
 public:
   bool visitFDiv(BinaryOperator &I);
-  bool visitXor(BinaryOperator &I);
 
   bool visitInstruction(Instruction &I) { return false; }
   bool visitBinaryOperator(BinaryOperator &I);
@@ -900,31 +899,6 @@ bool AMDGPUCodeGenPrepareImpl::visitFDiv(BinaryOperator &FDiv) {
   return !!NewFDiv;
 }
 
-bool AMDGPUCodeGenPrepareImpl::visitXor(BinaryOperator &I) {
-  // Match the Xor instruction, its type and its operands
-  IntrinsicInst *IntrinsicCall = dyn_cast<IntrinsicInst>(I.getOperand(0));
-  ConstantInt *RHS = dyn_cast<ConstantInt>(I.getOperand(1));
-  if (!RHS || !IntrinsicCall || RHS->getSExtValue() != -1)
-    return visitBinaryOperator(I);
-
-  // Check if the Call is an intrinsic instruction to amdgcn_class intrinsic
-  // has only one use
-  if (IntrinsicCall->getIntrinsicID() != Intrinsic::amdgcn_class ||
-      !IntrinsicCall->hasOneUse())
-    return visitBinaryOperator(I);
-
-  // "Not" the second argument of the intrinsic call
-  ConstantInt *Arg = dyn_cast<ConstantInt>(IntrinsicCall->getOperand(1));
-  if (!Arg)
-    return visitBinaryOperator(I);
-
-  IntrinsicCall->setOperand(
-      1, ConstantInt::get(Arg->getType(), Arg->getZExtValue() ^ 0x3ff));
-  I.replaceAllUsesWith(IntrinsicCall);
-  I.eraseFromParent();
-  return true;
-}
-
 static bool hasUnsafeFPMath(const Function &F) {
   Attribute Attr = F.getFnAttribute("unsafe-fp-math");
   return Attr.getValueAsBool();

diff  --git a/llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-foldnegate.ll b/llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-foldnegate.ll
deleted file mode 100644
index 296370e99bdfa4..00000000000000
--- a/llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-foldnegate.ll
+++ /dev/null
@@ -1,66 +0,0 @@
-; RUN: opt -mtriple=amdgcn-amd-amdhsa -amdgpu-codegenprepare -verify -S %s -o - | FileCheck %s
-
-declare i1 @llvm.amdgcn.class.f32(float, i32) nounwind readnone
-declare i1 @llvm.amdgcn.class.f64(double, i32) nounwind readnone
-
-; Trivial case, xor instruction should be removed and
-; the second argument of the intrinsic call should be
-; bitwise-negated
-; CHECK: @fold_negate_intrinsic_test_mask
-; CHECK: %1 = call i1 @llvm.amdgcn.class.f32(float %x, i32 1018)
-define i1 @fold_negate_intrinsic_test_mask(float %x) nounwind {
-  %1 = call i1 @llvm.amdgcn.class.f32(float %x, i32 5)
-  %2 = xor i1 %1, -1
-  ret i1 %2
-}
-
-; Trivial case, xor instruction should be removed and
-; the second argument of the intrinsic call should be
-; bitwise-negated
-; CHECK: @fold_negate_intrinsic_test_mask_dbl
-; CHECK: %1 = call i1 @llvm.amdgcn.class.f64(double %x, i32 1018)
-define i1 @fold_negate_intrinsic_test_mask_dbl(double %x) nounwind {
-  %1 = call i1 @llvm.amdgcn.class.f64(double %x, i32 5)
-  %2 = xor i1 %1, -1
-  ret i1 %2
-}
-
-; Negative test: should not transform for variable test masks
-; CHECK: @fold_negate_intrinsic_test_mask_neg_var
-; CHECK: %[[X0:.*]] = alloca i32
-; CHECK: %[[X1:.*]] = load i32, ptr addrspace(5) %[[X0]]
-; CHECK: call i1 @llvm.amdgcn.class.f32(float %x, i32 %[[X1]])
-; CHECK: xor
-define i1 @fold_negate_intrinsic_test_mask_neg_var(float %x) nounwind {
-  %1 = alloca i32, addrspace(5)
-  store i32 7, ptr addrspace(5) %1
-  %2 = load i32, ptr addrspace(5) %1
-  %3 = call i1 @llvm.amdgcn.class.f32(float %x, i32 %2)
-  %4 = xor i1 %3, -1
-  ret i1 %4
-}
-
-; Negative test: should not transform for multiple uses of the
-;   intrinsic returned value
-; CHECK: @fold_negate_intrinsic_test_mask_neg_multiple_uses
-; CHECK: %[[X1:.*]] = call i1 @llvm.amdgcn.class.f32(float %x, i32 7)
-; CHECK: store i1 %[[X1]]
-; CHECK: %[[X2:.*]] = xor i1 %[[X1]]
-define i1 @fold_negate_intrinsic_test_mask_neg_multiple_uses(float %x) nounwind {
-  %y = alloca i1, addrspace(5)
-  %1 = call i1 @llvm.amdgcn.class.f32(float %x, i32 7)
-  %2 = xor i1 %1, -1
-  store i1 %1, ptr addrspace(5) %y
-  %3 = xor i1 %1, -1
-  ret i1 %2
-}
-
-; Negative test: should not transform for a xor with no operand equal to -1
-; CHECK: @fold_negate_intrinsic_test_mask_neg_one
-; CHECK: %[[X0:.*]] = call i1 @llvm.amdgcn.class.f32(float %x, i32 7)
-; CHECK: xor i1 %[[X0]], false
-define i1 @fold_negate_intrinsic_test_mask_neg_one(float %x) nounwind {
-  %1 = call i1 @llvm.amdgcn.class.f32(float %x, i32 7)
-  %2 = xor i1 %1, false
-  ret i1 %2
-}