[PATCH] D154734: [WebAssembly] Report error for inline assembly with unsupported opcodes

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 11:41:17 PDT 2023


sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp:129
+              SMLoc(),
+              Twine("Wasm globals should only be accessed symbolically!"));
         default:
----------------
Is this error specific to inline assembly?

Looking at `global_set_expected_expression_operand` in `llvm/test/MC/WebAssembly/type-checker-errors.s` I see a different error.. so I guess maybe it fails before it gets here in the case to non-inline assembly?

I wonder if we shouldn't just allow this.. even though its kind odd to want to do it.. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154734/new/

https://reviews.llvm.org/D154734



More information about the llvm-commits mailing list