[PATCH] D154210: AMDGPU: Add some notes about amdgpu-flat-work-group-size

[Siu Chi Chan via Phabricator via llvm-commits]

scchan added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:1004
+                                             with more restrictive bounds by default depending on the language.
+                                             The behavior is undefined if the number of logically active lanes
+                                             exceeds the upper limit of this range at any point in the execution.
----------------
yaxunl wrote:
> if the actual block size or workgroup size exceeds the limit, the behaviour will be undefined. For example, even if there is only one active thread but the thread local id exceeds the limit, the behaviour is undefined.
I agree, the nuance here is to refer to the actual work group size at execution time exceeding the limit rather than the number of logical active lanes. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154210/new/

https://reviews.llvm.org/D154210