[PATCH] D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 7 09:11:39 PDT 2023
RKSimon marked 3 inline comments as not done.
RKSimon added inline comments.
================
Comment at: llvm/test/CodeGen/X86/h-register-addressing-64.ll:67
+; CHECK-NEXT: andl $2040, %esi # imm = 0x7F8
+; CHECK-NEXT: movzbl (%rdi,%rsi), %eax
; CHECK-NEXT: retq
----------------
pengfei wrote:
> RKSimon wrote:
> > Regression (WIP)
> I saw you removed WIP in the title. Are you not considering this as regression or you will do it as a follow up?
Let me take another look - it seems to be due to matchAddressRecursively not being very good at peeking through ZERO_EXTEND nodes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146121/new/
https://reviews.llvm.org/D146121
More information about the llvm-commits
mailing list