[PATCH] D150696: [LV] Vectorization remark for outerloop

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM with inline comments, thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1036
 
+/// Report successful vectorization of the loop. In a case if outer loop is
+/// vectorized, prepend "outer" to the vectorization remark
----------------



nit: `In case an outer loop is vectorized, ` + period at end of sentence. But it would also be OK to remove the last sentence IMO.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1047
+                              TheLoop->getHeader())
+           << "vectorized " << LoopType << "loop (vectorization width: "
+           << ore::NV("VectorizationFactor", VF.Width)
----------------
here it will use `outerloop`  whereas above it will use `outer loop`. It would be good to use `outer loop` in both cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150696/new/

https://reviews.llvm.org/D150696