[PATCH] D154717: [LV] Check if ops can safely be truncated in computeMinimumValueSizes.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:585
 
     // Non-instructions terminate a chain successfully.
     if (!isa<Instruction>(Val))
----------------
We're effectively working around this.

Does make me wonder: If we make the Worklist work on Uses rather than Values, could we handle this directly in this loop?


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:661
     for (Value *M : llvm::make_range(ECs.member_begin(I), ECs.member_end())) {
       if (!isa<Instruction>(M))
         continue;
----------------
dyn_cast up here, use below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154717/new/

https://reviews.llvm.org/D154717