[PATCH] D150851: [LoopVectorize] Vectorize select-cmp reduction pattern for increasing integer induction variable

Ramkumar Ramachandra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 05:43:12 PDT 2023


artagnon added a comment.

In D150851#4480312 <https://reviews.llvm.org/D150851#4480312>, @Mel-Chen wrote:

> Update: I could found an example where the approach in D152693 <https://reviews.llvm.org/D152693> lead to incorrect result:
> Assuming `start_value` is 3, and `red_part` is {0, 1, 2, 3} in the end. If the 3 is updated from the loop, not from the `start_value` , `red` should be 3 instead of 2.
>
> @artagnon, could you please help to verify it?

Yes, I can confirm that there is indeed a bug. Thanks for catching it! I'm thinking about a fix now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150851/new/

https://reviews.llvm.org/D150851



More information about the llvm-commits mailing list