[PATCH] D147990: [BPF] Undo transformation for LICM.cpp:hoistMinMax()

[Eduard Zingerman via Phabricator via llvm-commits]

eddyz87 added a comment.

In D147990#4479561 <https://reviews.llvm.org/D147990#4479561>, @yonghong-song wrote:

> sounds good to me. could you summarize what caused the memory leak and what is the fix?

For some reason I used the following sequence to remove unused instructions (e.g. min/max intrinsic calls):

  I->dropAllReferences();
  I->removeFromParent();

While correct way to do it is:

  I->eraseFromParent();

I have this noted alongside sha's of first commit and revert in the git commit message locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147990/new/

https://reviews.llvm.org/D147990