[PATCH] D149759: [symbolizer] Support symbol lookup

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 17:55:40 PDT 2023


ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp:266-269
+    if (!Config.IsAddr2Line && !Request.Symbol.empty())
+      OS << Request.Symbol << '\n';
+    else
+      OS << DILineInfo::Addr2LineBadString << ":0\n";
----------------
The conditions with fewer negations are much easier to understand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149759/new/

https://reviews.llvm.org/D149759



More information about the llvm-commits mailing list