[PATCH] D152081: [Attributor] Add lightweight version for attribute deduction only. (WIP)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Overall LGTM. We can iterate in tree. A few suggestions below.



================
Comment at: llvm/lib/Passes/PassRegistry.def:204
 CGSCC_PASS("openmp-opt-cgscc", OpenMPOptCGSCCPass())
 CGSCC_PASS("no-op-cgscc", NoOpCGSCCPass())
 #undef CGSCC_PASS
----------------
Can you please add it here too


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:3793
+  });
+  AC.Allowed = &Allowed;
+
----------------
AC.UseLiveness = false;


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:3931
+      AM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
+  AnalysisGetter AG(FAM);
+
----------------



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:3958
+      AM.getResult<FunctionAnalysisManagerCGSCCProxy>(C, CG).getManager();
+  AnalysisGetter AG(FAM);
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152081/new/

https://reviews.llvm.org/D152081