[PATCH] D149367: Emit the CodeView `S_ARMSWITCHTABLE` debug symbol for jump tables

[Daniel Paoliello via Phabricator via llvm-commits]

dpaoliello marked an inline comment as done.
dpaoliello added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:481
+  // Jump table debug info is only needed if CodeView is enabled.
+  if (DAG.getMachineFunction().getMMI().getModule()->getCodeViewFlag()) {
+    Chain = DAG.getJumpTableDebugInfo(JTI, Chain, dl);
----------------
efriedma wrote:
> I apologize for the run-around on this, but I just realized we shouldn't use getCodeViewFlag() here because it'll cause codegen to change based on whether debug info is enabled, which we try to avoid.
> 
> Maybe just check isOSBinFormatCOFF().
No worries: done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149367/new/

https://reviews.llvm.org/D149367