[PATCH] D153479: [NFC] Tests for future commit in DAGCombiner

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/combine_andor_with_cmps.ll:18-19
+; CHECK-NEXT:    s_setpc_b64 s[30:31]
+  %cmp1 = icmp slt i32 %arg1, 1000
+  %cmp2 = icmp slt i32 %arg2, 1000
+  %or  = or i1 %cmp1, %cmp2
----------------
Do you need tests where these use different constants?


================
Comment at: llvm/test/CodeGen/AMDGPU/combine_andor_with_cmps.ll:274-275
+; CHECK-NEXT:    s_setpc_b64 s[30:31]
+  %cmp1 = icmp slt i32 %arg1, 1000
+  %cmp2 = icmp slt i32 %arg2, 1000
+  %and  = and i1 %cmp1, %cmp2
----------------
Some tests where the compare types don't match?


================
Comment at: llvm/test/CodeGen/AMDGPU/combine_andor_with_cmps.ll:1100
+
+attributes #0 = { nounwind readnone }
----------------
Don't need these attributes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153479/new/

https://reviews.llvm.org/D153479