[PATCH] D149367: Emit the CodeView `S_ARMSWITCHTABLE` debug symbol for jump tables
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 6 14:00:22 PDT 2023
efriedma added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:481
+ // Jump table debug info is only needed if CodeView is enabled.
+ if (DAG.getMachineFunction().getMMI().getModule()->getCodeViewFlag()) {
+ Chain = DAG.getJumpTableDebugInfo(JTI, Chain, dl);
----------------
I apologize for the run-around on this, but I just realized we shouldn't use getCodeViewFlag() here because it'll cause codegen to change based on whether debug info is enabled, which we try to avoid.
Maybe just check isOSBinFormatCOFF().
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149367/new/
https://reviews.llvm.org/D149367
More information about the llvm-commits
mailing list