[PATCH] D154637: [CSSPGO] Fix ICE that callee samples returns null while finding import functions

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

Consider changing to title to "[SamplePGO] ..." since this is fixing an issue not specific to CSSPGO.



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1079
+    // for:
+    // 1. Repalyed function.
+    // 2. Callee target is changed during inlining. For example: During
----------------
typo: Replayed


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1083
+    // indirect call function to a direct call function, new callee target may
+    // not exist in the profile.
     if (!Samples) {
----------------
Could mention more in the comment about that this is a problem with a stale profile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154637/new/

https://reviews.llvm.org/D154637