[PATCH] D154639: [WebAssembly] Add frexp{f,l} libcall signatures

[Derek Schuff via Phabricator via llvm-commits]

dschuff created this revision.
Herald added subscribers: pmatos, asb, wingo, sunfish, hiraditya, jgravelle-google, sbc100.
Herald added a project: All.
dschuff requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

The llvm.frexp.* family of intrinsics and their corresponding libcalls were
recently added, which means we need to know their signatures.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154639

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
  llvm/test/CodeGen/WebAssembly/libcalls.ll


Index: llvm/test/CodeGen/WebAssembly/libcalls.ll
===================================================================
--- llvm/test/CodeGen/WebAssembly/libcalls.ll
+++ llvm/test/CodeGen/WebAssembly/libcalls.ll
@@ -19,8 +19,11 @@
 declare double @llvm.log.f64(double)
 declare double @llvm.exp.f64(double)
 declare double @llvm.ldexp.f64.i32(double, i32)
+declare {double, i32} @llvm.frexp.f64.i32(double)
 declare i32 @llvm.lround(double)
 
+declare void @escape_value(i32)
+
 define fp128 @fp128libcalls(fp128 %x, fp128 %y, i32 %z) {
   ; compiler-rt call
 ; CHECK-LABEL: fp128libcalls:
@@ -234,21 +237,42 @@
 define double @f64libcalls(double %x, double %y, i32 %z) {
 ; CHECK-LABEL: f64libcalls:
 ; CHECK:         .functype f64libcalls (f64, f64, i32) -> (f64)
+; CHECK-NEXT:    .local i32
 ; CHECK-NEXT:  # %bb.0:
-; CHECK-NEXT:    local.get $push12=, 0
-; CHECK-NEXT:    local.get $push9=, 0
-; CHECK-NEXT:    call $push0=, cos, $pop9
+; CHECK-NEXT:    global.get $push10=, __stack_pointer
+; CHECK-NEXT:    i32.const $push11=, 16
+; CHECK-NEXT:    i32.sub $push15=, $pop10, $pop11
+; CHECK-NEXT:    local.tee $push14=, 3, $pop15
+; CHECK-NEXT:    global.set __stack_pointer, $pop14
+; CHECK-NEXT:    local.get $push20=, 3
+; CHECK-NEXT:    local.get $push19=, 0
+; CHECK-NEXT:    local.get $push16=, 0
+; CHECK-NEXT:    call $push0=, cos, $pop16
 ; CHECK-NEXT:    call $push1=, log10, $pop0
-; CHECK-NEXT:    local.get $push10=, 1
-; CHECK-NEXT:    call $push2=, pow, $pop1, $pop10
-; CHECK-NEXT:    local.get $push11=, 2
-; CHECK-NEXT:    call $push3=, __powidf2, $pop2, $pop11
+; CHECK-NEXT:    local.get $push17=, 1
+; CHECK-NEXT:    call $push2=, pow, $pop1, $pop17
+; CHECK-NEXT:    local.get $push18=, 2
+; CHECK-NEXT:    call $push3=, __powidf2, $pop2, $pop18
 ; CHECK-NEXT:    call $push4=, log, $pop3
 ; CHECK-NEXT:    call $push5=, exp, $pop4
 ; CHECK-NEXT:    call $push6=, cbrt, $pop5
 ; CHECK-NEXT:    call $push7=, lround, $pop6
-; CHECK-NEXT:    call $push8=, ldexp, $pop12, $pop7
-; CHECK-NEXT:    return $pop8
+; CHECK-NEXT:    call $push8=, ldexp, $pop19, $pop7
+; CHECK-NEXT:    call llvm.frexp.f64.i32, $pop20, $pop8
+; CHECK-NEXT:    local.get $push22=, 3
+; CHECK-NEXT:    f64.load $push21=, 0($pop22)
+; CHECK-NEXT:    local.set 0, $pop21
+; CHECK-NEXT:    local.get $push23=, 3
+; CHECK-NEXT:    i32.load $push9=, 8($pop23)
+; CHECK-NEXT:    call escape_value, $pop9
+; CHECK-NEXT:    local.get $push24=, 3
+; CHECK-NEXT:    i32.const $push12=, 16
+; CHECK-NEXT:    i32.add $push13=, $pop24, $pop12
+; CHECK-NEXT:    global.set __stack_pointer, $pop13
+; CHECK-NEXT:    local.get $push25=, 0
+; CHECK-NEXT:    return $pop25
+
+
  %a = call double @llvm.cos.f64(double %x)
  %b = call double @llvm.log10.f64(double %a)
  %c = call double @llvm.pow.f64(double %b, double %y)
@@ -258,7 +282,11 @@
  %g = call fast double @llvm.pow.f64(double %f, double 0x3FD5555555555555)
  %h = call i32 @llvm.lround(double %g)
  %i = call double @llvm.ldexp.f64.i32(double %x, i32 %h);
- ret double %i
+ %result = call {double, i32} @llvm.frexp.f64.i32(double %i)
+ %result.0 = extractvalue { double, i32 } %result, 0
+ %result.1 = extractvalue { double, i32 } %result, 1
+ call void @escape_value(i32 %result.1)
+ ret double %result.0
 }
 
 ; fcmp ord and unord (RTLIB::O_F32 / RTLIB::UO_F32 etc) are a special case (see
Index: llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
@@ -248,6 +248,9 @@
     Table[RTLIB::LDEXP_F32] = f32_func_f32_i32;
     Table[RTLIB::LDEXP_F64] = f64_func_f64_i32;
     Table[RTLIB::LDEXP_F128] = i64_i64_func_i64_i64_i32;
+    Table[RTLIB::FREXP_F32] = f32_func_f32_i32;
+    Table[RTLIB::FREXP_F64] = f64_func_f64_i32;
+    Table[RTLIB::FREXP_F128] = i64_i64_func_i64_i64_i32;
 
     // Conversion
     // All F80 and PPCF128 routines are unsupported.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154639.537820.patch
Type: text/x-patch
Size: 4028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230706/5b16fbcb/attachment.bin>