[PATCH] D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 10:06:39 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6036
+  // predicate and have a common operand.
+  auto AreSameCMPsAndHaveCommonOperand = [&]() {
+    if (LHS->getOpcode() != ISD::SETCC || RHS->getOpcode() != ISD::SETCC)
----------------
Is this just using LHS/RHS? Use explicit arguments and drop the default capture all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153502/new/

https://reviews.llvm.org/D153502



More information about the llvm-commits mailing list