[PATCH] D154571: [emacs] Highlight 'zeroext' and 'signext' keyword as an attribute

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 10:06:17 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM, but the patch description refers to the wrong attributes.

> Out of curiosity, do you use emacs or are you just a kind soul to review this?

Nope, I use vim :)



================
Comment at: llvm/utils/emacs/llvm-mode.el:30
          "shadowcallstack" "speculatable" "speculative_load_hardening" "ssp" "sspreq" "sspstrong" "safestack" "sanitize_address" "sanitize_hwaddress" "sanitize_memtag"
-         "sanitize_thread" "sanitize_memory" "strictfp" "swifterror" "uwtable" "vscale_range" "willreturn" "writeonly" "immarg") 'symbols) . font-lock-constant-face)
+         "sanitize_thread" "sanitize_memory" "strictfp" "swifterror" "uwtable" "vscale_range" "willreturn" "writeonly" "immarg" "zeroext" "signext") 'symbols) . font-lock-constant-face)
    ;; Variables
----------------
The attributes here are (mostly) sorted, so maybe but signext next to shadowcallstack?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154571/new/

https://reviews.llvm.org/D154571



More information about the llvm-commits mailing list